Updated app Dockerfile to install Node 20 from NodeSource #3169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion, which is not compatible with the NodeSource Node 20
|
🛡 Test Coverage Report 🛡
📜 Click to view full text coverage report |
Collaborator
Author
|
These changes were merged in with PR 3170. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://staff.loc.gov/tasks/browse/CONCD-1392
Unfortunately, there's no simple first-party way to get Node 20 on to a Bookworm image except by using a different base image--in which case, we'd need to do this same thing, only with Python 3.12 instead. NodeSource appears to be the standard third-party way to accomplish this.
The other alternative should be to copy Node from the bookworm Node 20 image, but that seems more error prone, and would leave our install of Node outside the apt system, so it could only be updated when the base image itself was updated, which would complicate, e.g., security updates, since we would need to wait for the underlying image to update rather than simply being able to grab the latest version with apt, like we can do by using NodeSource.
Removing the installation of node-gyp caused gcc and other packages needed for compiling some Python packages to not be installed, so I explicitly installed build-essential.
I also upgraded our version of Vite to the latest, since that was waiting on the upgrade to Node 20.