add bindable text path to BindableButton component#71
Open
DenisZhukovski wants to merge 2 commits intoLibraStack:mainfrom
Open
add bindable text path to BindableButton component#71DenisZhukovski wants to merge 2 commits intoLibraStack:mainfrom
DenisZhukovski wants to merge 2 commits intoLibraStack:mainfrom
Conversation
Author
|
@ChebanovDD could you please take a look |
ChebanovDD
reviewed
Mar 28, 2024
Collaborator
ChebanovDD
left a comment
There was a problem hiding this comment.
Why not simply use BindableLabel?
<ui:UXML xmlns:uitk="UnityMvvmToolkit.UITK.BindableUIElements" ...>
<uitk:BindableButton ...>
<uitk:BindableLabel ... /> <!--Using BindableLabel to display button text.-->
</uitk:BindableButton>
</ui:UXML>
Author
As for me it gives better flexibility, Button already has text property and why not to bind on it? In the future button implementation may be changed and we will be independent. Also internal button label can have some style class names automatically assigned which you may forget once do it manually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.