Fix docs's expected results and document limitations #65
Merged
fantazio merged 8 commits intoLexiFi:masterfrom Mar 23, 2026
Merged
Fix docs's expected results and document limitations #65fantazio merged 8 commits intoLexiFi:masterfrom
fantazio merged 8 commits intoLexiFi:masterfrom
Conversation
Some values were wrongly expected to be reported as used twice : - Those in `functor_lib.mli` (`External_param.*`) are actually only used once. - Those in `modtyp_lib.mli` (`M_subst.*`) should not be reported at all because they belong to module type `T`.
This fixes the duplicated reports in case a module is included within its compilation unit (LexiFi#57).
This replaces the previous fix for internal includes. It also fixes the invalid tracking and reporting of values coming from module types with substition.
…p unit This fixes the potential duplicate use for values in modules used as functor parameters outside their compilation units.
Reflect the recent fix on the example
Document the module type limitation and issue LexiFi#64 As for the examples, code presented in the limitations is added to the testsuite.
A significant part of a previous code review's suggestion was left out when applying the suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The expected results for the
functorandmodtypexamples were wrong for thethreshold-*scenarios.They are are fixed and their uncovered invalid results are fixed too. On the way, the PR also fixes #57.
The documentation is updated to explicit list known limitations :
Listed limitations have their code examples included in the testsuite, like the other examples in the docs.