Epic/cv jedi minimalism #283 create contact section#338
Epic/cv jedi minimalism #283 create contact section#338AbelDeTena wants to merge 7 commits intoLemoncode:epic/cv-jedi-minimalismfrom
Conversation
AbelDeTena
changed the base branch from
feature/develop
to
epic/cv-jedi-minimalism
| @@ -0,0 +1,98 @@ | |||
| <%_ if (profile.relevantLinks && profile.relevantLinks !== 0) { -%> | |||
There was a problem hiding this comment.
if (profile.relevantLinks && profile.relevantLinks.length > 0)
| /> | ||
| </svg> | ||
| </div> | ||
| <a href="tel:+#">+1 041 234 5678</a> |
There was a problem hiding this comment.
If we have phone display phone. Add a condition and use props to display phone
There was a problem hiding this comment.
replace by <%=link.URL%>
| /> | ||
| </svg> | ||
| </div> | ||
| <a href="mailto:#">user@email.com</a> |
There was a problem hiding this comment.
replace by <%=link.URL%>
| </defs> | ||
| </svg> | ||
| </div> | ||
| <a href="#" target="_blank">https://linkedin.com/in/david-bonilla</a> |
There was a problem hiding this comment.
replace by <%=link.URL%>
| /> | ||
| </svg> | ||
| </div> | ||
| <a href="#" target="_blank">https://github.com/dbonilla</a> |
There was a problem hiding this comment.
replace by <%=link.URL%>
| /> | ||
| </svg> | ||
| </div> | ||
| <a href="#" target="_blank">https://twitter/david-bonilla</a> |
There was a problem hiding this comment.
replace by <%=link.URL%>
| /> | ||
| </svg> | ||
| </div> | ||
| <a href="#" target="_blank">https://www.david-bonilla.com</a> |
There was a problem hiding this comment.
replace by <%=link.URL%>
…e/manfred-export-app into epic/cv-jedi-minimalism
AbelDeTena
force-pushed
the
epic/cv-jedi-minimalism-#283-create-contact-section
branch
from
c1d5c26 to
55dbc95
Compare
… phones, emails o location
| @@ -0,0 +1,117 @@ | |||
| <%_ if (profile.relevantLinks && profile.relevantLinks.length > 0 || profile.phoneNumbers && profile.phoneNumbers.length > 0 ||profile.emails && profile.emails.length > 0 || profile.city && profile.country ) { -%> | |||
There was a problem hiding this comment.
This is wrong. You can get the country but not the city. Replace by:
<%_ if (profile.relevantLinks && profile.relevantLinks.length > 0 || profile.emails && profile.emails.length > 0 || profile.city || profile.country || profile.phoneNumbers && profile.phoneNumbers.length > 0) { -%>
|
|
||
| <h2>Contact</h2> | ||
| <div class="aside__container"> | ||
| <%_ for (const number of profile?.phoneNumbers) { -%> |
There was a problem hiding this comment.
Two thinks:
- What happen here if we have relevantLinks por example, but not phoneNumbers?
- profile.phoneNumbers is an array, number is an item in the array
You change this, if we have phoneNumbers we display phones
| /> | ||
| </svg> | ||
| </div> | ||
| <a href="tel:+#"><%=profile.phoneNumbers[0].countryCode%> <%=profile.phoneNumbers[0].number%></a> |
There was a problem hiding this comment.
It`s wrong: number.countryCode and number.phoneNumber
| <%_ } %> | ||
| <%_ } -%> | ||
|
|
||
| <%_ for (const email of profile?.emails) { -%> |
| <%_ } %> | ||
| <%_ } -%> | ||
|
|
||
| <%_ if (profile.city && profile.country) { -%> |
| </div> | ||
| <%_ } %> | ||
|
|
||
| <%_ for (const link of profile?.relevantLinks) { -%> |
There was a problem hiding this comment.
What happen here if we don't have relevantLinks?
There was a problem hiding this comment.
Refer to the file relevants-links-section.ejs in cv-monochrome-force and try to correct this file.
2 participants
No description provided.