Skip to content

Enable pro mode to allow all options #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Menkib64 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enable pro mode to allow all options #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60eff1e
Enable pro mode to allow all options
Menkib64 Apr 26, 2026
1c8846f
Rename old cached binaries
Menkib64 Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Client/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ def read_git_credentials(engine):


def engine_binary_name(engine, commit_sha, net_path, private):
name = '%s-%s' % (engine, commit_sha.upper()[:8])
name = '%s-pro-%s' % (engine, commit_sha.upper()[:8])
if net_path and not private:
name += '-%s' % (net_path[-8:])
return name
Comment on lines 153 to 157
Copy link

Copilot AI Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

engine_binary_name() now unconditionally inserts -pro- into the engine binary filename. This changes the on-disk naming scheme for all engines, so existing cached binaries (built/downloaded under the previous <engine>-<sha> naming) will no longer be detected by check_for_engine_binary(), forcing rebuilds/re-downloads and potentially leaving duplicate/orphaned engine binaries. If the intent is to enable a new optional “pro mode”, consider making the -pro- suffix conditional (e.g., behind an explicit flag) and/or add backward-compatible lookup to reuse the old filename when present.

Copilot uses AI. Check for mistakes.
Expand Down Expand Up @@ -311,6 +311,14 @@ def download_network(server, username, password, engine, net_name, net_sha, net_

def download_public_engine(engine, net_path, branch, source, make_path, out_path, compiler=None):

old_out_path = out_path.replace('-pro', '')
if check_for_engine_binary(old_out_path):
print('Rename [%s] to [%s]' % (old_out_path, out_path))
if IS_WINDOWS:
os.rename(old_out_path + '.exe', out_path + '.exe')
else:
os.rename(old_out_path, out_path)

# Check to see if we already have the binary
if check_for_engine_binary(out_path):
print('Found [%s-%s]' % (engine, branch))
Expand Down
2 changes: 1 addition & 1 deletion Client/worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@

## Basic configuration of the Client. These timeouts can be changed at will

CLIENT_VERSION = 35 # Client version to send to the Server
CLIENT_VERSION = 36 # Client version to send to the Server
TIMEOUT_HTTP = 30 # Timeout in seconds for HTTP requests
TIMEOUT_ERROR = 10 # Timeout in seconds when any errors are thrown
TIMEOUT_WORKLOAD = 30 # Timeout in seconds between workload requests
Expand Down
2 changes: 1 addition & 1 deletion Config/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"client_version" : 35,
"client_version" : 36,
"client_repo_url" : "https://github.com/LeelaChessZero/OpenBench",
"client_repo_ref" : "master",

Expand Down