Skip to content

Conversation

@farivar-tabatabaei
Copy link

@farivar-tabatabaei farivar-tabatabaei commented Dec 26, 2025

This pull request improves the user experience when deploying contracts with specific tags in the Hardhat deployment task. Now, if a user specifies tags but no contracts are deployed (and there are no errors), the tool will warn the user accordingly. The test expectations have been updated to reflect this new behavior.

Deployment task improvements:

  • Added a check in deploy.ts to warn the user if tags are specified but no deploy scripts match, and set a non-zero exit code in this case.

Test updates:

  • Updated the test expectation file deploy-all-missing-tag.exp to expect the new warning message when no deploy scripts match the specified tag.

Fixes #1066
feat(deploy): add warning for no deployed contracts with specified tags

…tName`

Fixes LayerZero-Labs#1066
feat(deploy): add warning for no deployed contracts with specified tags
@cursor
Copy link

cursor bot commented Dec 26, 2025

PR Summary

Improves feedback for tagged deployments that result in no changes.

  • In deploy.ts, after aggregating results, computes totalDeployedContracts and, if selectedTags are provided with zero deployments and no errors, logs a warning (No contracts were deployed), sets process.exitCode, and returns early
  • Updates deploy-all-missing-tag.exp to expect the new warning instead of the success message

Written by Cursor Bugbot for commit 44ae34b. This will update automatically on new commits. Configure here.

@farivar-tabatabaei farivar-tabatabaei changed the title Fix issue bug: lz:deploy requires deploy task name matches `contracts... Fix issue bug: lz:deploy requires deploy task name matches contractName Dec 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: lz:deploy requires deploy task name matches contractName

1 participant