-
Notifications
You must be signed in to change notification settings - Fork 256
build: fix foundryup line #1854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚨 E2E Tests FailedThe E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:
This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information. |
🚨 E2E Tests FailedThe E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:
This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information. |
🚨 E2E Tests FailedThe E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:
This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information. |
🚨 E2E Tests FailedThe E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:
This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information. |
🚨 E2E Tests FailedThe E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:
This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information. |
|
This can be merged if #1856 is successful |
|
CI with new image succeeds: #1856 |
|
building from latest main after this PR's merge: https://github.com/LayerZero-Labs/devtools/actions/runs/19790604266 |
Diagnosis
results in
version 1.4.4 not installedrefer to the failing run of build base image on main: https://github.com/LayerZero-Labs/devtools/actions/runs/19776463219/job/56669775441#step:3:4296
turns out,
we need to do
that
vis important.basically,
foundryup -ujust looks for the folder under FOUNDRY_DIR named exactly what you pass itand if we installed 1.4.4. the directory would be
FOUNDRY_DIR/versions/v1.4.4so doing only
foundryup -u 1.4.4.would mean it looks forFOUNDRY_DIR/versions/1.4.4which does not existProof of Successful Build Image Run
https://github.com/LayerZero-Labs/devtools/actions/runs/19777418103
Proof of successful CI with new image
#1856