[lua, sql, cpp] Add weighted weaponskill for trusts, useWeaponSkill on entity, and Valaineral updates#9708
[lua, sql, cpp] Add weighted weaponskill for trusts, useWeaponSkill on entity, and Valaineral updates#9708lefneer311 wants to merge 0 commit intoLandSandBoat:basefrom
Conversation
|
@Xaver-DaRed - are there any adjustments needed on this one? |
CI is failing due to duplicate spells and certain clang-tidy issues. I suggest you click on the failed checks at the bottom of the PR page and review the logs carefully. |
Ah! I see what happened. Thank you for the gentle pointer toward the obvious. |
d7f1581 to
9e922dd
Compare
|
Prior to my force-push today, I pulled a fresh copy of LSB/server:base and made the same edits I had staged in my development fork (including those called out by clang), recompiled, and re-tested to confirm they were still valid. Everything tested successfully locally with a 20260410 pull. |
|
PR #9718 ironically modified several of the same files in a similar fashion. Converting to draft to review and resolve conflicts. |
I affirm:
What does this pull request do?
This pull request does the following:
My changes were tested against a fresh Release x64 build pulled and compiled on 2026-03-31.
Steps to test these changes
For the weighted_ws modifications, you can modify any trust you like to include a weighted_ws table, and a gambit to make use of ai.s.WEIGHTED_WS, launch the server, summon that trust, and observe their weaponskill behavior. Reference Valaineral.lua for an example of how to add weights.
For the useWeaponSkill(), this is best demonstrated with Valaineral. Summon Valaineral, engage a mob and swing so Valaineral engages. Unlock from your target and use a spell or job ability (or another means of engaging) another mob. Bring that mob near Valaineral and watch him use Uriel Blade. The logic follows retail as closely as I'm aware of at this time.
Screenshots below are from tests performed against Wajaom Woodlands Lesser Colibri at level 75.