Skip to content

feat: add SetGroupMessageReactionReq message for group reaction handling #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Redmomn merged 1 commit into from
Mar 23, 2026
+8 −1
Merged

feat: add SetGroupMessageReactionReq message for group reaction handling #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion proto/service/v2/oidb.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ message Oidb {
optional uint32 reserved = 12;
}

message GenericEmptyRspBody {}

message D102AReqBody {
repeated string domain = 1;
}
Expand Down Expand Up @@ -404,4 +406,9 @@ message DED3ReqBody {
optional uint32 nudge_type = 6;
}

Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DED3RspBody appears to have been removed and replaced by SetGroupMessageReactionReq. Removing an existing message from a published proto is a breaking change for downstream code generation/compatibility. If DED3RspBody is still a valid response type, re-add it (optionally mark as deprecated) and add the new reaction request message separately.

Suggested change
message DED3RspBody {
option deprecated = true;
}

Copilot uses AI. Check for mistakes.
message DED3RspBody {}
message SetGroupMessageReactionReq {
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SetGroupMessageReactionReq starts field numbering at tag 2, leaving tag 1 unaccounted for. If tag 1 exists in the upstream schema but is intentionally omitted here, add reserved 1; (or define the missing field) to prevent accidental reuse and to make the wire layout explicit.

Suggested change
message SetGroupMessageReactionReq {
message SetGroupMessageReactionReq {
reserved 1;

Copilot uses AI. Check for mistakes.
optional int64 group_uin = 2;
optional uint32 sequence = 3;
optional string code = 4;
optional uint32 type = 5; // 1 face 2 emoji
}
Comment on lines +409 to +414
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In proto/service/v2/oidb.proto, request/response messages consistently use the *ReqBody / *RspBody suffix pattern (e.g., D102AReqBody, DeleteFileReqBody). SetGroupMessageReactionReq is the only request message in this file that doesn't follow that convention; consider renaming to SetGroupMessageReactionReqBody (and adding a matching *RspBody type if applicable) to keep generated APIs consistent for consumers.

Copilot uses AI. Check for mistakes.
Loading