This repository was archived by the owner on Oct 12, 2025. It is now read-only.
[Core] Fix #841 #843
Merged
[Core] Fix #841 #843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
DarkRRb
requested review from
a user,
Decrabbityyy,
Executor-Cheng,
KusaGumina,
Linwenxuan04,
Copilot,
pk5ls20 and
sisi0318
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses issue #841 by fixing a resource reuse bug in the serialization process within the MessageRecord implicit conversion from MessageChain. The changes include refactoring the serialization logic to use a dedicated MemoryStream and returning the byte array from the stream to ensure correct serialization.
KusaGumina
approved these changes
May 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.