fix: multiple issues #510, #511, #515, #516#522
Merged
ogazboiz merged 4 commits intoMay 29, 2026
Conversation
Pass abort signal to fetchStream and fetchEvents functions. Abort on cleanup or when streamId changes to prevent "setState on unmounted component" races and cancel stale in-flight requests. Ignore AbortError in catch blocks. Closes LabsCrypt#510
Call URL.revokeObjectURL after download is triggered to free memory. Prevents object URL leaks on repeated CSV exports. Closes LabsCrypt#511
deploy.ts had incompatible differences with deploy.sh: - Argument format: --network=testnet vs --network testnet - Environment variable: STELLAR_SECRET_KEY vs DEPLOYER_SECRET - Network argument semantics: RPC URL vs network name The README documents deploy.sh as canonical. Keep deploy.sh as single source of truth for deployments. Closes LabsCrypt#515
Remove unused loop that calculates claimableOutTotal in getUserStreamSummary. The value is never included in the returned summary object, so the computation is wasted per request. Closes LabsCrypt#516
0dfcdfc to
0e3ec77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes four issues in the FlowFi project plus one pre-existing contract bug:
Changes
Frontend
Backend
Infra
Contract
Test Plan
Known Issues
The contract code has pre-existing duplicate function definitions that should be resolved separately:
pause_streamdefined twice (lines 322 and 652 in lib.rs)resume_streamdefined twice (lines 365 and 687 in lib.rs)