GitHub Issue 465: Add auditing capabilities for grid views#2887
Open
GitHub Issue 465: Add auditing capabilities for grid views#2887
Conversation
cnathe
approved these changes
Feb 16, 2026
Comment on lines
+229
to
+230
| checker().verifyTrue("Expected at least 1 audit event for shared default view save.", | ||
| !defaultViewAuditRows.isEmpty()); |
Contributor
There was a problem hiding this comment.
is there ever a valid case where there would be more than 1 audit event row? if not, could this just be changed to an assert that the list length is 1?
Contributor
Author
There was a problem hiding this comment.
I've added comment that explains why there could be 1 or 2 events. If the current default view for this user is "private", saving a "shared" default view will actually be 2 events. One for creating the shared, one for deleting the old private view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Related Pull Requests
Changes