Tests for multi choice value by DariaBod · Pull Request #2872 · LabKey/testAutomation

DariaBod · 2026-02-05T18:55:35Z

Rationale

Some changes to support multi choice

Related Pull Requests

Tests for multi choice value#1971

Changes

Added setAllowMultipleSelections method to check “Allow multiple selections” checkbox 
Changed method initFilterColumn for work with filters for List values 
Added method testMultiChoiceValues() to ListTest (scope: create, edit) 
Created new shuffleSelect() for random amount of random values from list 
Changed method selectOptionByText() for multi choice values. If we need value to be selected we first check if it’s selected and then click

- SMProAssayCreateTest.testAddResultFields - SMSampleCreateTest.testSamplesWithMultiChoice - SMSourceTypeMultiChoiceTest - ListTest.testMultiChoiceValues

…ag() fix test testMultiChoiceEditInBulk()

-add new shuffleSelect -replace my method with shuffleSelect

labkey-danield

Added a few comments.

labkey-danield · 2026-02-09T17:11:38Z

src/org/labkey/test/components/domain/DomainFormPanel.java

+                    if(textChoiceValidator.getMultipleSelections())
+                    {
+                        fieldRow.setAllowMultipleSelections(textChoiceValidator.getMultipleSelections());
+                    }


This will only set it if textChoiceValidator.getMultipleSelections is true, correct? This is ok if you are creating a field, but wouldn't work as expected if the test is editing an existing field and wants to change to field from a multi-choice to a single choice.
Perhaps a better check would be:
if(null != textChoiceValidator.getMultipleSelections())

labkey-danield · 2026-02-09T17:21:25Z

src/org/labkey/test/components/ui/grids/EditableGrid.java

+            lookupSelect.clearSelection();
+


Will this work if a test is trying to add to an existing selections?

I would expect a method called setCellValue to overwrite any existing value.

labkey-tchad · 2026-02-06T22:20:51Z

src/org/labkey/test/components/domain/DomainFormPanel.java

+                    if(textChoiceValidator.getMultipleSelections())
+                    {
+                        fieldRow.setAllowMultipleSelections(textChoiceValidator.getMultipleSelections());
+                    }


This would make it impossible to disable multi-select through this method.
This should either call setAllowMultipleSelections unconditionally or the condition should check whether textChoiceValidator.getMultipleSelections() != null.

src/org/labkey/test/components/ui/search/FilterFacetedPanel.java

labkey-tchad · 2026-02-06T23:10:59Z

src/org/labkey/test/components/ui/grids/ResponsiveGrid.java

                List<String> values = (List<String>) value;
                filterModal.selectFacetTab().selectValue(values.get(0));
                filterModal.selectFacetTab().checkValues(values.toArray(String[]::new));
+                filterModal.selectFacetTab().selectFilter(operator.getDisplayValue());


I think this will (or could) break functionality for other column types; the facet panel usually doesn't have a filter type.
Also, this wouldn't work for "Is Empty" or "Is Not Empty".

I’m planning to add support for 'Is Empty' and 'Is Not Empty' as well.

Regarding the functionality for other types: I’ve already found one test that was failing, so I added a check to the initFilterColumn method. It now checks if the filter type selector is present on the page before trying to interact with it. After this change, the test is passing.

Does this approach sound okay to you?

src/org/labkey/test/pages/query/UpdateQueryRowPage.java

labkey-tchad · 2026-02-07T00:25:25Z

src/org/labkey/test/pages/DatasetInsertPage.java

        for (Map.Entry<String, String> entry : values.entrySet())
        {
-            WebElement fieldInput = Locator.name(EscapeUtil.getFormFieldName(entry.getKey())).findElement(getDriver());
+            WebElement fieldInput = Locator.nameContaining(EscapeUtil.getFormFieldName(entry.getKey())).findElement(getDriver());


Use a more precise locator and add a comment explaining why this can't match the name exactly. (See UpdateQueryRowPage)

labkey-tchad · 2026-02-07T00:42:31Z

src/org/labkey/test/tests/list/ListTest.java

+        table.clickInsertNewRow();
+        String valuesToChoose = tcValues.subList(1, 3).stream()
+                .sorted()
+                .collect(Collectors.joining(" "));
+        Locator loc = Locator.nameContaining(EscapeUtil.getFormFieldName(columnName));
+        selectOptionByText(loc, valuesToChoose);


clickInsertNewRow returns a page object that should have methods for setting fields.

src/org/labkey/test/tests/list/ListTest.java

labkey-tchad · 2026-02-09T18:41:07Z

src/org/labkey/test/WebDriverWrapper.java

+        if(Boolean.parseBoolean(selectElement.getAttribute("multiple"))) {
+            List<WebElement> elems = selectElement.findElements(Locator.tag("option"));
+            elems.forEach(element->{
+                if(value.contains(element.getAttribute("value")) ^ element.isSelected()) element.click();
+            });
+            return;
+        }


This is less precise than we like for broadly available helpers; it would get confused by selection options that have overlapping text. I would suggest having a separate method for multi-select (selectOptionsByText(WebElement selectElement, List<String> values).

src/org/labkey/test/tests/list/ListTest.java

Co-authored-by: Trey Chadick <tchad@labkey.com>

- Test fixes for change from quoted values to bold in error messages

getConversionErrorMessage() fix to message case for invalid date/timestamp now quoting field name for consistency

Co-authored-by: Trey Chadick <tchad@labkey.com>

# Conflicts: # src/org/labkey/test/pages/query/UpdateQueryRowPage.java

labkey-tchad

I think Xing is going to work on the Java remote API. This PR is blocked by that update.

labkey-tchad · 2026-02-16T21:45:04Z

src/org/labkey/test/components/ui/grids/EditableGrid.java

+            lookupSelect.clearSelection();
+


I would expect a method called setCellValue to overwrite any existing value.

labkey-tchad · 2026-02-16T22:34:18Z

src/org/labkey/test/components/ui/search/FilterFacetedPanel.java

+     * Select a filer by clicking its label. Right now this method relevant only for multi-value text choice.
+     * @param operator desired filter value
+     */
+    public void selectFilter(Filter.Operator operator)


A slightly more descriptive method name.

Suggested change

public void selectFilter(Filter.Operator operator)

public void selectArrayFilterOperator(Filter.Operator operator)

labkey-tchad · 2026-02-16T22:41:22Z

src/org/labkey/test/components/ui/search/FilterFacetedPanel.java

+        protected final ReactSelect filterTypeSelects =
+                new ReactSelect.ReactSelectFinder(getDriver()).index(0).findWhenNeeded(this);


Making name consistent with method rename suggestion.

Suggested change

protected final ReactSelect filterTypeSelects =

new ReactSelect.ReactSelectFinder(getDriver()).index(0).findWhenNeeded(this);

protected final ReactSelect arrayFilterOperatorSelect =

new ReactSelect.ReactSelectFinder(getDriver()).index(0).findWhenNeeded(this);

labkey-tchad · 2026-02-16T22:43:04Z

src/org/labkey/test/components/ui/search/FilterFacetedPanel.java

+     */
+    public boolean isFiltersPresented()
+    {
+        return waitFor(() -> isVisible(elementCache().filterTypeSelects), 1000);


We shouldn't wait for things that might not be present, especially when the most common state is for it to not be present.

labkey-tchad · 2026-02-16T23:03:15Z

src/org/labkey/test/pages/query/UpdateQueryRowPage.java

+        WebElement field = elementCache().findField(fieldName, true);
+        List<WebElement> options = field.findElements(By.tagName("option"));
+       //unselect all options that selected but shouldn't be selected
+        options.forEach(option ->
+        {
+            if (!values.contains(option.getText()) && option.getAttribute("selected") != null) option.click();
+        });
+        values.forEach(value -> selectOptionByText(field, value));
+        return this;


WebDriver's Select class handles multi-select.

Suggested change

WebElement field = elementCache().findField(fieldName, true);

List<WebElement> options = field.findElements(By.tagName("option"));

//unselect all options that selected but shouldn't be selected

options.forEach(option ->

{

if (!values.contains(option.getText()) && option.getAttribute("selected") != null) option.click();

});

values.forEach(value -> selectOptionByText(field, value));

return this;

WebElement field = new Select(elementCache().findField(fieldName, true));

field.deselectAll();

values.forEach(value -> field.selectByVisibleText(value));

return this;

labkey-tchad · 2026-02-16T23:05:38Z

src/org/labkey/test/pages/query/UpdateQueryRowPage.java

        return this;
    }

+    public UpdateQueryRowPage setField(String fieldName, List<String> values)


This can replace the existing setMultiValueField that was added last week. It only has one usage and doesn't actually support multiple values.

labkey-tchad · 2026-02-16T23:25:52Z

src/org/labkey/test/components/domain/DomainFormPanel.java

+                    fieldRow.setAllowMultipleSelections(false);
+                }
+                else if (validator instanceof FieldDefinition.MultiValueTextChoiceValidator multiValueTextChoiceValidator)
+                {
+                    // MultiValueTextChoice is a field type; implemented using a special validator. TextChoice field cannot have other validators.
+                    if (validators.size() > 1)
+                    {
+                        throw new IllegalArgumentException("TextChoice fields cannot have additional validators.");
+                    }
+                    fieldRow.setTextChoiceValues(multiValueTextChoiceValidator.getValues());
+                    fieldRow.setAllowMultipleSelections(true);


MultiValueTextChoiceValidator is redundant. We can just check the column type to decide whether to allow multiple selections.

Suggested change

fieldRow.setAllowMultipleSelections(false);

}

else if (validator instanceof FieldDefinition.MultiValueTextChoiceValidator multiValueTextChoiceValidator)

{

// MultiValueTextChoice is a field type; implemented using a special validator. TextChoice field cannot have other validators.

if (validators.size() > 1)

{

throw new IllegalArgumentException("TextChoice fields cannot have additional validators.");

}

fieldRow.setTextChoiceValues(multiValueTextChoiceValidator.getValues());

fieldRow.setAllowMultipleSelections(true);

fieldRow.setAllowMultipleSelections(fieldDefinition.getType() == FieldDefinition.ColumnType.MultiValueTextChoice);

}

labkey-tchad · 2026-02-16T23:26:37Z

src/org/labkey/test/params/FieldDefinition.java

+     * to an external data source. The user only provides the list of (string) values that the field will display in the dropdown.
+     * Another difference is that there can only be one TextChoice on a field, whereas you can have multiple validators on a field.
+     */
+    public static class MultiValueTextChoiceValidator extends FieldValidator<MultiValueTextChoiceValidator>


MultiValueTextChoiceValidator is redundant and should be removed.

labkey-tchad · 2026-02-16T23:39:45Z

src/org/labkey/test/components/ui/grids/ResponsiveGrid.java


    private GridFilterModal initFilterColumn(CharSequence columnIdentifier, Filter.Operator operator, Object value)
    {
+        List<Filter.Operator> listOperators = List.of(IN, CONTAINS_ALL, CONTAINS_ANY, CONTAINS_EXACTLY, CONTAINS_NONE,
+                DOES_NOT_CONTAIN_EXACTLY);


IN isn't actually a list operator (this component just uses it as a signal to use the checkboxes). It shouldn't be grouped with them. This list should also be static and contain the empty operators.

Suggested change

private GridFilterModal initFilterColumn(CharSequence columnIdentifier, Filter.Operator operator, Object value)

{

List<Filter.Operator> listOperators = List.of(IN, CONTAINS_ALL, CONTAINS_ANY, CONTAINS_EXACTLY, CONTAINS_NONE,

DOES_NOT_CONTAIN_EXACTLY);

public static final List<Filter.Operator> ARRAY_OPERATORS = List.of(CONTAINS_ALL, CONTAINS_ANY, CONTAINS_EXACTLY, CONTAINS_NONE, DOES_NOT_CONTAIN_EXACTLY, IS_EMPTY, IS_NOT_EMPTY);

private GridFilterModal initFilterColumn(CharSequence columnIdentifier, Filter.Operator operator, Object value)

{

labkey-tchad · 2026-02-16T23:49:23Z

src/org/labkey/test/components/ui/grids/ResponsiveGrid.java

-            if (operator.equals(Filter.Operator.IN) && value instanceof List<?>)
+            if (listOperators.contains(operator) && value instanceof List<?>)
            {
                List<String> values = (List<String>) value;
-                filterModal.selectFacetTab().selectValue(values.get(0));
-                filterModal.selectFacetTab().checkValues(values.toArray(String[]::new));
+                FilterFacetedPanel filterPanel = filterModal.selectFacetTab();
+                filterPanel.selectValue(values.get(0));
+                filterPanel.checkValues(values.toArray(String[]::new));
+                if (filterPanel.isFiltersPresented())
+                {
+                    filterPanel.selectFilter(operator);
+                }
+            }
+            else if (value == null)
+            {
+                filterModal.selectFacetTab().selectFilter(operator);
            }


Now that I have a better understanding of these new filter operators, I have a better idea for this method. We don't actually need to check whether the operator select is present; for the new operators, the select will always be present.
Something like this:

if (operator.equals(Filter.Operator.IN) && value instanceof List<?> || ARRAY_OPERATORS.contains(operator)) { FilterFacetedPanel filterPanel = filterModal.selectFacetTab(); if (ARRAY_OPERATORS.contains(operator)) { filterPanel.selectFilter(operator); } if (value != null) { List<String> values = (List<String>) value; filterPanel.selectValue(values.get(0)); filterPanel.checkValues(values.toArray(String[]::new)); } }

XingY · 2026-02-17T01:15:25Z

I think Xing is going to work on the Java remote API. This PR is blocked by that update.

LabKey/labkey-api-java#88

DariaBod added 10 commits January 23, 2026 13:40

initial commit for multichoice value

333c490

some changes

fabe096

add tests for:

349d08d

- SMProAssayCreateTest.testAddResultFields - SMSampleCreateTest.testSamplesWithMultiChoice - SMSourceTypeMultiChoiceTest - ListTest.testMultiChoiceValues

Merge branch 'develop' into fb_mvtc_test

0ab67be

new changes for test

fd9d700

Merge branch 'develop' into fb_mvtc_test

bf42d09

Merge branch 'develop' into fb_mvtc_test

1745585

add test testMultiChoiceUpdateFromFile(), testMultiChoiceEditInGridDr…

f349d82

…ag() fix test testMultiChoiceEditInBulk()

Merge branch 'develop' into fb_mvtc_test

92000dd

Merge branch 'develop' into fb_mvtc_test

c3c8266

DariaBod changed the title ~~Fb mvtc test~~ Tests for multi choice value Feb 5, 2026

DariaBod requested a review from labkey-danield February 5, 2026 19:10

DariaBod added 2 commits February 5, 2026 11:13

-delete unused imports

e5ec9db

-delete unexpected symbol

33683e0

LabKey deleted a comment from github-actions bot Feb 5, 2026

-some code style fixes

9a5773a

-add new shuffleSelect -replace my method with shuffleSelect

DariaBod requested a review from labkey-tchad February 5, 2026 23:18

labkey-danield reviewed Feb 9, 2026

View reviewed changes

labkey-tchad reviewed Feb 9, 2026

View reviewed changes

src/org/labkey/test/tests/list/ListTest.java Show resolved Hide resolved

DariaBod and others added 10 commits February 10, 2026 16:58

Apply suggestion from @labkey-tchad

41e1c78

Co-authored-by: Trey Chadick <tchad@labkey.com>

Provide warnings for unknown fields for cross sample type import (#2862)

36a970a

- Test fixes for change from quoted values to bold in error messages

Dismiss popover for responsive grid (#2874)

bac1f69

Misc fixes for error message single quote change (#2876)

c44cbd6

getConversionErrorMessage() fix to message case for invalid date/timestamp now quoting field name for consistency

Fix expected error messages in tests (#2875)

c60c514

Fix build: remove import in ListDateAndTimeTest (#2879)

fe04f1f

Updating SampleFinder Test Component (#2877)

0435138

fix comments about selectFilter javadoc and initFilterColumn method

b4d52e0

Merge branch 'develop' into fb_mvtc_test

fd83f85

Apply suggestions from code review

6648cf1

Co-authored-by: Trey Chadick <tchad@labkey.com>

DariaBod and others added 7 commits February 13, 2026 09:41

Apply suggestions from code review

d1751b3

Co-authored-by: Trey Chadick <tchad@labkey.com>

Move getExpectedAuditDataChange method to AuditLogHelper. (#2880)

187e9b4

Make CSP error logging validation more robust (#2868)

7c72826

Merge branch 'refs/heads/develop' into fb_mvtc_test

e9aab1d

# Conflicts: # src/org/labkey/test/pages/query/UpdateQueryRowPage.java

fix all pr comments

87c688b

fixed study and list tests

6cab358

Merge branch 'develop' into fb_mvtc_test

987b284

DariaBod mentioned this pull request Feb 16, 2026

Test multi choice field for Dataset LabKey/platform#7411

Merged

DariaBod marked this pull request as ready for review February 16, 2026 20:46

DariaBod requested review from XingY, labkey-danield and labkey-tchad February 16, 2026 20:49

labkey-tchad requested changes Feb 17, 2026

View reviewed changes

	public void selectFilter(Filter.Operator operator)
	public void selectArrayFilterOperator(Filter.Operator operator)

		protected final ReactSelect filterTypeSelects =
		new ReactSelect.ReactSelectFinder(getDriver()).index(0).findWhenNeeded(this);

Conversation

DariaBod commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale

Related Pull Requests

Changes

Uh oh!

labkey-danield left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

labkey-tchad left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

XingY commented Feb 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

DariaBod commented Feb 5, 2026 •

edited

Loading