Update GridBar.setAliquotView to be more reliable #2807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed some errors for calculated columns when running on MSSQL. Use RegEx to validate time values if milliseconds are expected. Trim double value returned from DB. Wait for grid refresh when applying a view choice.
Wait for various elements, etc...
labkey-danield
changed the title
labkey-tchad
approved these changes
Dec 9, 2025
Comment on lines
365
to
366
| String finalMenuChoice = menuChoice; | ||
| _queryGrid.doAndWaitForUpdate(()->doMenuAction(currentButtonText, Arrays.asList(finalMenuChoice))); |
Member
There was a problem hiding this comment.
Creating this extra final variable isn't necessary. menuChoice can be made final by removing its initial assignment and adding a default branch to the view switch.
Reverting call to doAndWaitForUpdate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Update GridBar.setAliquotView to be more reliable
Related Pull Requests
Changes