Skip to content

Conversation

@labkey-danield
Copy link
Contributor

@labkey-danield labkey-danield commented Dec 8, 2025

Rationale

Addressing some failures in SsampleTypeRenameTest

TeamCity run.

Related Pull Requests

  • None

Changes

  • Dismiss the grid menu.
  • Refresh page to check for link to sample type.

Comment on lines 182 to 183
// Dismiss the menu so it doesn't get in the way.
menu.findVisibleMenuItems().get(0).sendKeys(Keys.ESCAPE);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the menu's collapse method work?

Suggested change
// Dismiss the menu so it doesn't get in the way.
menu.findVisibleMenuItems().get(0).sendKeys(Keys.ESCAPE);
// Dismiss the menu so it doesn't get in the way.
menu.collapse();

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

@labkey-danield labkey-danield merged commit e276197 into develop Dec 9, 2025
6 checks passed
@labkey-danield labkey-danield deleted the fb_sampleTypeRenameTestFix branch December 9, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants