Skip to content

SM Test Fixes #2717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
labkey-danield merged 10 commits into from
Oct 2, 2025
Merged

SM Test Fixes #2717

labkey-danield merged 10 commits into from
Oct 2, 2025

Conversation

@labkey-danield
Copy link
Contributor

@labkey-danield labkey-danield commented Oct 1, 2025 •
edited
Loading

Rationale

Fixing some tesst issue

Related Pull Requests

Changes

  • Assert that QueryGrid.clearAllSelections does what it says it will do.
  • Per suggestions from Allan use Locator.byClass rather than Locator.tagWitClass.
  • SampleTypeAPIHelper.getRowIdsForSamples use json to pass the list of sample ids to the API
  • In TestDataGenerator.isNameInvalidLocal change regular expression to work if " -" is the last character in the domain name.

@labkey-danield labkey-danield self-assigned this Oct 1, 2025
@labkey-danield
Assert that QueryGrid.clearAllSelections works.
3813599 
Use a valid domain name in SMSampleTypeDesignerTest.testParentAndSourceAliasOptions
Change the order of clearing the filters and selections in SMProMoveAssayRunsTest.configureGrid
@labkey-danield
Merge branch 'develop' into fb_smTestFixes
7cfc57a
@labkey-danield labkey-danield requested a review from XingY October 1, 2025 19:37
XingY
XingY reviewed Oct 1, 2025
View reviewed changes
src/org/labkey/test/util/exp/SampleTypeAPIHelper.java Outdated
while (iterator.hasNext()) {
String sampleName = iterator.next();

json.append("\"");
Copy link
Contributor

@XingY XingY Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use EscapeUtil.toJSONStr

Copy link
Contributor Author

@labkey-danield labkey-danield Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@labkey-danield
Implementing code review feedback.
0527284 
Dismissing banner messages after moving assay runs.
Using EscapeUtil.toJSONStr to build json string.
Added BannerHelper.dismissAllBannerMessages
@labkey-danield labkey-danield merged commit 2453c1a into develop Oct 2, 2025
8 of 9 checks passed
@labkey-danield labkey-danield deleted the fb_smTestFixes branch October 2, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XingY XingY XingY approved these changes

@labkey-susanh labkey-susanh labkey-susanh approved these changes

Assignees

@labkey-danield labkey-danield

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@labkey-danield @XingY @labkey-susanh