Skip to content

Fix test failures due to admin console link changes #2302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-adam merged 2 commits into from
Feb 27, 2025
Merged

Fix test failures due to admin console link changes #2302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87ccbec
Fix test failures due to admin console link changes
labkey-adam Feb 21, 2025
002c215
Merge remote-tracking branch 'origin/develop' into fb_admin_csp_sources
labkey-adam Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/org/labkey/test/pages/core/admin/ShowAdminPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public void clickAnalyticsSettings()
clickAndWait(elementCache().analyticsSettingsLink);
}

public void clickExternalRedirectHosts()
public void clickAllowedExternalRedirectHosts()
{
goToSettingsSection();
clickAndWait(elementCache().externalRedirectHostLink);
Expand Down Expand Up @@ -273,7 +273,7 @@ protected class ElementCache extends LabKeyPage.ElementCache
protected WebElement sectionActiveUsers = Locator.linkWithText("Active Users").findWhenNeeded(this);

protected WebElement analyticsSettingsLink = Locator.linkWithText("analytics settings").findWhenNeeded(this);
protected WebElement externalRedirectHostLink = Locator.linkWithText("external redirect hosts").findElement(this);
protected WebElement externalRedirectHostLink = Locator.linkWithText("allowed external redirect hosts").findElement(this);
protected WebElement auditLogLink = Locator.linkWithText("audit log").findWhenNeeded(this);
protected WebElement auditLogMaintenanceLink = Locator.linkWithText("Audit Log Maintenance").findWhenNeeded(this);
protected WebElement authenticationLink = Locator.linkWithText("authentication").findWhenNeeded(this);
Expand Down
2 changes: 1 addition & 1 deletion src/org/labkey/test/tests/AdminConsoleTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ public void testAppAdminRole()
public void testConfigureReturnURL()
{
String host = "google.com";
goToAdminConsole().clickExternalRedirectHosts();
goToAdminConsole().clickAllowedExternalRedirectHosts();

log("Verifying host cannot be blank ");
clickButton("Save");
Expand Down
2 changes: 1 addition & 1 deletion src/org/labkey/test/tests/core/security/TroubleshooterRoleTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ protected void verifySitePermissionSetting(boolean canSave)
isElementPresent(Locator.tagWithText("span","Save")));

log("Verify permissions for External Redirect Hosts");
goToAdminConsole().goToSettingsSection().clickExternalRedirectHosts();
goToAdminConsole().goToSettingsSection().clickAllowedExternalRedirectHosts();
checker().verifyEquals("Incorrect access for External Redirect Hosts", canSave,
isElementPresent(Locator.tagWithText("span","Save")));

Expand Down