Skip to content

Add some waits for elements. #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-danield merged 1 commit into from
Nov 18, 2025
Merged

Add some waits for elements. #1133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/src/org/labkey/test/tests/targetedms/TargetedMSQCConfigureMetricTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ private void verifyOutlierCount(String replicate, QCPlotsWebPart.MetricType metr
QCSummaryWebPart qcSummaryWebPart = new PanoramaDashboard(this).getQcSummaryWebPart();
qcSummaryWebPart.gotoUtilizationCalendar();
qcSummaryWebPart = new QCSummaryWebPart(getDriver());
waitForElement(Locator.tagContainingText("div", replicate));
scrollIntoView(Locator.tagContainingText("div", replicate));
mouseOver(Locator.tagContainingText("div", replicate));
mouseOver(Locator.tagContainingText("div", replicate));
Expand Down
3 changes: 3 additions & 0 deletions test/src/org/labkey/test/tests/targetedms/TargetedMSQCGuideSetTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,9 @@ public void testSmallMoleculePareto() throws IOException, CommandException
verifyGuideSetSmallMoleculeStats(gsSmallMolecule);

clickAndWait(Locator.linkWithText("Pareto Plot")); //go to Pareto Plot tab
Locator.tagWithClass("div", "x4-mask-msg-text")
.withText("Loading...").waitForElementToDisappear(getDriver(), 15_000);

ParetoPlotPage paretoPage = new ParetoPlotPage(getDriver());
ParetoPlotsWebPart paretoPlotsWebPart = paretoPage.getParetoPlotsWebPart();

Expand Down
4 changes: 4 additions & 0 deletions test/src/org/labkey/test/tests/targetedms/TargetedMSTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,10 @@ protected void ensureComparisonPlots(String title)

protected void verifyQcSummary(int sampleFileCount, int precursorCount)
{
Locator.tagWithClass("div", "x4-panel")
.withDescendant(Locator.tagWithText("label", "Loading..."))
.waitForElementToDisappear(getDriver(), 15_000);

QCSummaryWebPart qcSummaryWebPart = new PanoramaDashboard(this).getQcSummaryWebPart();
verifyQcSummary(qcSummaryWebPart.getQcSummaryTiles().get(0), null, sampleFileCount, precursorCount);
}
Expand Down
Loading