Cache precursor-scoped metrics for better reporting performance #1129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankurjuneja
approved these changes
Oct 28, 2025
|
|
||
| -- Ensure we have transition areas for peptides or small molecules | ||
| AND (EXISTS ( | ||
| SELECT Id, FragmentType, Quantitative FROM Transition t |
Contributor
There was a problem hiding this comment.
Could the two EXISTS subqueries being used multiple times be moved into a separate sql file and also, would using a JOIN than two EXISTS improve perf here?
Contributor
Author
There was a problem hiding this comment.
Good idea. I restored the transition and precursor area enabled queries and used them here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
On very large databases, the QC plots and other reports can be sluggish to load, especially on parent folders that have multiple QC subfolders.
We can improve perf by caching all of the precursor-scoped metric values in a dedicated table. We then maintain it as Skyline documents are added or removed, or metrics are added or removed.
Changes
targetedms.QCMetricCachetable