Improve QC folder plot controls #1120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@cnathe could you give the UI changes a code review? |
cnathe
approved these changes
Oct 10, 2025
| this.lastParsedResponse = JSON.parse(response.responseText); | ||
| this.processPlotData(); | ||
| // Ignore if not the most recent request | ||
| if (requestSeq !== this._qcRequestSeq) |
Contributor
There was a problem hiding this comment.
since we are calling this._qcActiveRequest.abort() before creating a new request, it seems like this case of "not the most recent request" shouldn't be hit. Is this just for the rare case where we don't abort in time?
Contributor
Author
There was a problem hiding this comment.
Yes. It might be overkill for this scenario, but what I saw was that abort() can still be subject to a race condition. I would have thought that JS's default threading model would make this a non-issue, but decided to do both since it wasn't much extra work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
We've accumulated a lot of controls for Panorama's QC plots. We can do a better job of arranging them and explaining them.
Changes