Skip to content

Fixed join in SND snapshot dataset source (BSC) #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
spamhurts merged 2 commits into from
Jun 17, 2025
Merged

Fixed join in SND snapshot dataset source (BSC) #823

spamhurts merged 2 commits into from
Jun 17, 2025
+1 −1

Conversation

@spamhurts
Copy link
Collaborator

@spamhurts spamhurts commented Jun 16, 2025

added criteria to join on a specific lookup ID

Copilot AI reviewed Jun 16, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines the join between the Categories.BCS table and Lookups to only include matching lookup IDs, preventing unrelated rows from being returned.

  • Added b.bcs = l.lookupId to the INNER JOIN on SND.Lookups.

@spamhurts spamhurts merged commit 9c056bd into release25.3-SNAPSHOT Jun 17, 2025
6 checks passed
@spamhurts spamhurts deleted the 25.3_fb_fixSndSourceQuery branch June 17, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@jallentxbiomed jallentxbiomed jallentxbiomed approved these changes

@RameshRapa RameshRapa Awaiting requested review from RameshRapa

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@spamhurts @jallentxbiomed