Convert FeeScheduleController to use FileLike #820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-bpatel
commented
Apr 11, 2025
snprc_ehr/src/org/labkey/snprc_ehr/controllers/FeeScheduleController.java
Outdated
Show resolved
Hide resolved
…d(), and handlePost().
Sigmonia
approved these changes
Apr 14, 2025
Contributor
Sigmonia
left a comment
Sigmonia
left a comment
There was a problem hiding this comment.
I like the approach you took here.
| return new JspView<>("/org/labkey/snprc_ehr/pipeline/FeeScheduleImport.jsp", form, errors); | ||
| } | ||
|
|
||
| private File getVerifiedFile(String filePath) |
Contributor
There was a problem hiding this comment.
@labkey-matthewb Would it be generally useful to have this a helper method on the Piperoot/PipelineService? Adding either the root or the container as a parameter makes this validation pretty generic for parsing incoming file paths.
Contributor
Author
There was a problem hiding this comment.
@labkey-ians I was wondering the same
Contributor
Author
There was a problem hiding this comment.
@labkey-ians Since @labkey-matthewb is out this week, we can table this discussion and come back to it. In the meantime, I'll merge the PR.
labkey-klum
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Secure controller action/API endpoints that might allow unauthorized access to the files on the server by using FileLike instead of File (String) or File (String, String) patterns.
Related Pull Requests
Changes