Skip to content

Upgrade XMLBeans to 5.3.0 #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
labkey-adam wants to merge 2 commits into from
Closed

Upgrade XMLBeans to 5.3.0 #966

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
192887d
Upgrade XMLBeans to 5.3.0
labkey-adam Jan 11, 2025
1e83916
Update comment
labkey-adam Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ antVersion=1.10.13

#Unifying version used by DISCVR and Premium
apacheDirectoryVersion=2.1.7
#Transitive dependency of Apache directory: 2.0.18 contains some regressions
#Transitive dependency of Apache directory: 2.2.3 is flagged with a CVE
apacheMinaVersion=2.2.4

# Usually matches the version specified as a Spring Boot dependency (see springBootVersion below)
Expand Down Expand Up @@ -319,4 +319,4 @@ xercesImplVersion=2.12.2
xmlApisVersion=1.0.b2

# sync with Tika/POI
xmlbeansVersion=5.2.0
xmlbeansVersion=5.3.0
Copy link
Contributor

@labkey-nicka labkey-nicka Jan 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: On develop, when running gradle commands I'm seeing the XMLBeans version get logged when I don't think i was previously. Here is an example running pickPg:

image

Is this something we're logging? Is it useful? If not, could it be removed?

Copy link
Contributor Author

@labkey-adam labkey-adam Jan 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@labkey-nicka Yes, we're logging the XMLBeans version in the Gradle Plugins and the server. As the PR comment suggests, we're trying to track down what seems like a version discrepancy between build time and run time. We'll remove the logging once we successfully upgrade.