GitHub Issue 604: Improve JobRunner job tracking and completion waiting #7286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-adam
requested changes
Dec 19, 2025
labkey-adam
approved these changes
Dec 19, 2025
| _executor.shutdown(); | ||
| } | ||
|
|
||
| public boolean awaitTermination(long timeout, @NotNull TimeUnit unit) throws InterruptedException |
Contributor
There was a problem hiding this comment.
Now that waitForCompletion() works for Runnables, isn't awaitTermination() redundant?
Contributor
There was a problem hiding this comment.
Regardless, a comment on these methods about use would be helpful.
Contributor
Author
There was a problem hiding this comment.
I consolidated. They had different semantics but the distinction wasn't important.
Always shutdown runners in unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
We should give equal handling to Runnables and Jobs
Changes