Survey : don't clear all form fields that may be hidden #7284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
We are currently clearing all hidden form elements in a survey panel. I don't remember the exact reason for this behavior but I can imagine with some skip logic where we hide/show elements we don't want those values posted, although I thought ExtJS forms prevented that automatically although maybe this is just for disabled elements.
This came up recently while trying to help a client where they needed a value posted without rendering a visible element in the form. The exact scenario is there is a value that needs to be dynamically calculated based on other behavior, so a listener is attached and the value of the hidden form field is updated on parent element changes.