Remove unused User parameters from service methods #7276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-adam
requested review from
labkey-jeckels,
labkey-matthewb,
labkey-nicka and
labkey-susanh
labkey-jeckels
approved these changes
Dec 18, 2025
This was referenced Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Some
ExperimentServiceandSampleTypeServicemethods take aUserparameter but ignore it, as of the related PR below. Remove this parameter from those signatures (and callers).There should be no functional changes here. I recommend relying on existing automated tests; no need for manual testing or additional automated tests.
Related Pull Requests