Second fix to filepaths outside the folder root with the XAR system, plus testing #7273
Conversation
Minor cleanup
(cherry picked from commit cbc6d0c)
|
WARNING: This PR appears to have the default title generated by GitHub. Please use something more descriptive. |
bbimber
changed the title
|
Good morning @labkey-jeckels: is this PR good to merge now? In the other thread you mentioned test/permission scenarios: from my perspective I think the XarTestPipelineJob cases in this PR, which include Folder<->/Shared and Workbook<->Parent, Workbook<->Sibling-Workbook, LK_Root<->Some-Other-FolderTree, span the use cases I can think of. If LabKey tightens file access permissions, I hope those scenarios can be included in other forms of automated testing that are written. |
|
Hi @labkey-jeckels and/o @XingY: sorry to bug you on this, but I think this satisfies everything Josh requested and the tests all passed overnight. This bug has been blocking our pipeline for almost a week so i'm very keen to get a fix deployed. I think we just need to approve/merge it - would it be possible to do so? Thanks. |
The thread on #7267 will actually be merged here, since this is the branch against which TeamCity runs, not the bbimber fork.