Admin UI for adding external hosts to a variety of directives #6359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ove junit test to interrogate the policy itself, not just related data structures.
…ndle cspVersion in report action. Labels and clean up HTML.
…CSP and report them via metrics.
…ew CaseInsensitiveHashSetValuedMap (with case-insensitive String values). Add validation.
… hosts, and allowed file extensions
Sigmonia
approved these changes
Feb 26, 2025
core/src/org/labkey/core/security/AllowedExternalResourceHosts.java
Outdated
Show resolved
Hide resolved
….java Co-authored-by: Ian Sigmon <labkey-ians@users.noreply.github.com>
Co-authored-by: Ian Sigmon <labkey-ians@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Admins need a way to allow browsers to retrieve resources from trusted external hosts as CSP exceptions.
https://docs.google.com/document/d/1aUreAxpjOi75Iqx0ZfdRJLrL-pUGFWAPYLdIsJTcO2A/edit?tab=t.0#heading=h.4rg4h5vuek0
Related Pull Requests
Changes
connect-src,font-src,frame-src,image-src, andstyle-src, though others can be added easily (seeDirective).