Check all managed modules for upgrade suitability #6211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-jeckels
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Previously, we excluded from the upgrade check modules with a VCS URL that was missing or in a format we didn't understand. The URL format wasn't consistent across servers and VCS URLs weren't present on dev machines by default, making the check unreliable (or maybe worthless). We required the VCS URL check because the
ManageVersionproperty defaulted to true... so, absent that check, an external module with a non-standard schema version that didn't specify ManageVersion would block the upgrade. We've now switched the default value to false, so ManageVersion solely determines whether we do the upgrade suitability check. All deployments should now consistently fail to startup if the installed version of any managed module is less than the earliest upgrade version (currently 24.000). https://www.labkey.org/home/Developer/issues/Secure/issues-details.view?issueId=47369Also, improve the information included in the upgrade blocked exception message.
Related Pull Requests