Assay: resolve a single provider/protocol before creating protocol schema #6057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnathe
approved these changes
Nov 15, 2024
…hema - avoids costly creation of AssayProtocolSchema of each assay defined in a container
labkey-nicka
force-pushed
the
fb_faster_assay
branch
from
22ded4e to
1bde87a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
When attempting to resolve a
TableInfofrom aDomainfor theAssayDomainKindwe currently iterate over all the assay definitions in a container and for each provider we callprovider.createProtocolSchema()and then hydrate fullTableInfoinstances until we find a match.This refactors the approach to first resolve the singularly desired provider and only induce the
provider.createProtocolSchema()call for that provider to then resolve theTableInfo.Related Pull Requests
Changes
AssayManager.getTableInfoForDomainId()by directly resolving the assay protocol/provider inAssayDomainKind.getTableInfo()and then instantiating a new schema for only that assay.AbstractAssayProvider.getDomains()intogetDomains()andgetDomainsAndDefaultValues()to makegetDomains()more clear in its role and what it will return (i.e. aList<Domain>rather than aList<Pair<Domain, Map<DomainProperty, Object>>>)assay-assayList.apimatching on protocol "name" and provider "type" to be case-insensitive.