Link crawler test #1402
Merged
Link crawler test #1402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@labkey-martyp, let me know if you'd like us to test this on our prime2507 VM. |
labkey-tchad
requested changes
Jul 29, 2025
Member
labkey-tchad
left a comment
labkey-tchad
left a comment
There was a problem hiding this comment.
AbstractONPRC_EHRTest should override testCrawlEhrLinks so that it only gets run in ONPRC_EHRTest but not ONPRC_EHRTest2 or ONPRC_BillingTest
labkey-tchad
previously approved these changes
Jul 31, 2025
Member
labkey-tchad
left a comment
labkey-tchad
left a comment
There was a problem hiding this comment.
Was ONPRC_EHRTest2 just working in the wrong folder all this time?
onprc_ehr/test/src/org/labkey/test/tests/onprc_ehr/AbstractGenericONPRC_EHRTest.java
Outdated
Show resolved
Hide resolved
…ericONPRC_EHRTest.java Co-authored-by: Trey Chadick <tchad@labkey.com>
Contributor
Author
Yes, they've all been using the project folder instead of the EHR folder. I've had it on my backlog to fix for a long time. Seemed like a good time to fix it. |
labkey-tchad
approved these changes
Aug 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Link crawler test validates links in the EHR folder. ONPRC tests have not used this folder in the past. This converts to using the EHR folder for tests, which more closely matches the production server.
Related Pull Requests
Changes