Behavior Obs Refinements #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import java.util.Map; | ||
| import java.util.Set; | ||
|
|
||
| public class NIRCBehaviorObservationsDataSource extends AbstractDataSource |
Contributor
There was a problem hiding this comment.
Would it be practical to extract shared code into a new parent class and have both NIRCBehaviorObservationsDataSource and NIRCClinicalObservationsDataSource extend it?
Contributor
Author
There was a problem hiding this comment.
Yes that is practical and done. Good call.
labkey-bpatel
approved these changes
Aug 5, 2025
Contributor
labkey-bpatel
left a comment
labkey-bpatel
left a comment
There was a problem hiding this comment.
Approved, but please see my comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
A handful of behavior obs refinements.
Changes