Discard forms #560
Merged
Discard forms #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-jeckels
approved these changes
Jul 21, 2025
Contributor
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
I didn't manually test but this seems safe to go without separate validation. Let me know if you'd prefer a manual check.
| protected List<String> getMoreActionButtonConfigs() | ||
| { | ||
| List<String> configs = super.getMoreActionButtonConfigs(); | ||
| configs.remove("DISCARD"); |
Contributor
There was a problem hiding this comment.
I would love to have constants for this and other actions. However, I know this is long-standing and widespread to use hard-coded strings.
Contributor
Author
There was a problem hiding this comment.
Yeah that could be a future EHR improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Add ability to discard forms to all non-case or necropsy related forms. Update clinremarks ETL to concat comment and diagnosis similar to cases.