Skip to content

Conversation

@labkey-danield
Copy link
Contributor

@labkey-danield labkey-danield commented Apr 28, 2025

Rationale

Some test fixes.

Related Pull Requests

Changes

  • Wait for updates to happen.
  • For workflow test use dates that are farther apart and less likely to collide.

Use dates that are farther apart and less likely to collide.
Wait for the element.
setFormElement(Locator.textarea("plan"), "Case plan");
setFormElement(Locator.name("Id"), animalId);
_helper.getExt4FieldForFormSection("Clinical Case", "Open Date").setValue(LocalDateTime.now().minusDays(1).format(_dateFormat));
_helper.getExt4FieldForFormSection("Clinical Case", "Open Date").setValue(LocalDateTime.now().minusDays(2).format(_dateFormat));
Copy link
Contributor

@labkey-martyp labkey-martyp Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@labkey-danield Looks like this is having a downstream affect on another test. When a clinical case is opened, daily observations start on that animal. I believe that is what is causing the row count to be off for testBehavioralCases. That test should probably be filtering on Observations before counting the rows.

What are we changing these dates for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@labkey-martyp I was seeing a failure with this test that was basically and end date wasn't after a before date (sorry I don't remember any more details).
I cannot remember where I was seeing that if it was on TeamCity or locally. Locally I run with the server in a different time zone, so maybe that was the issue.

At any rate I've backed out the changes to the DateTime values and have only left the simpler changes.

Let me know if you are ok with the those changes.

@labkey-danield labkey-danield deleted the 25.3_fb_studyTestFix branch May 5, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants