Go-live testing feedback updates #519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vation_types. Add 'source' to editable_lookups.
…ixed width on 'Description' column (we don't want that).
…s > Add From File
labkey-martyp
requested changes
Apr 21, 2025
Contributor
labkey-martyp
left a comment
labkey-martyp
left a comment
There was a problem hiding this comment.
Looks good. Just a few questions when you have time.
| <tables xmlns="http://labkey.org/data/xml"> | ||
| <table tableName="buildings" tableDbType="TABLE"> | ||
| <tableTitle>Buildings</tableTitle> | ||
| <javaCustomizer class="org.labkey.ehr.table.DefaultEHRCustomizer" /> |
Contributor
There was a problem hiding this comment.
What is this removed for?
Contributor
Author
There was a problem hiding this comment.
Since we display Building's Description column (labeled as 'Building'), there is a fixed width set on Description in DefaultEHRCustomizer, causing the column width to be unusually wide.
Contributor
Author
There was a problem hiding this comment.
As per our discussion, I've added this back and commented it out with a comment so we know why we are not using DefaultEHRCustomizer since there is a possibility of some work around Buildings.
nirc_ehr/src/org/labkey/nirc_ehr/dataentry/section/NIRCBirthFormSection.java
Outdated
Show resolved
Hide resolved
…r openRemark and closeRemark respectively; plus related changes.
labkey-martyp
approved these changes
Apr 22, 2025
…s view, given that there might be future updates involving Buildings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Updates following go-live testing feedback from the client.
Related Pull Requests
Changes