GitHub Issue 830: Assay design add transform script webdav path doesn't resolve from subfolder#1938
Open
GitHub Issue 830: Assay design add transform script webdav path doesn't resolve from subfolder#1938
Conversation
…'t resolve from subfolder - AssayProtocolModel.container to compare domain id to the container.parentId to get parentPath when applicable
XingY
reviewed
Feb 18, 2026
| : domainContainerId === container.id | ||
| ? container.path | ||
| : domainContainerId; | ||
| const domainContainerPath = |
Contributor
There was a problem hiding this comment.
I'm not sure this is the best way to fix this issue. Perhaps the path should be queried if containerId doesn't match, before constructing webdav url? This wouldn't work if editing a designer created from Shared project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
#830 LIMS: Adding a Tx script from within a subfolder fails
When editing an assay design and dropping a transform script, we use the AssayProtocolModel domain container Id to get the containerPath before posting to the webdav controller action. We were checking the module context container Id value but not the parentId value when resolving the containerPath on the client side. This PR checks both when getting the AssayProtocolModel.container
Related Pull Requests
Changes