Stop accepting deprecated properties #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-susanh
approved these changes
Jan 9, 2025
Contributor
labkey-susanh
left a comment
labkey-susanh
left a comment
There was a problem hiding this comment.
Changes seem good here. Please be sure to run a build on TeamCity with these changes at least once before merge.
src/main/groovy/org/labkey/gradle/plugin/extension/ModuleExtension.groovy
Show resolved
Hide resolved
src/main/groovy/org/labkey/gradle/plugin/extension/ModuleExtension.groovy
Show resolved
Hide resolved
Contributor
Author
|
Build and DRTs are successful: LabKey/server#964 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The
module.propertiespropertiesModuleDependencies,ConsolidateScripts, andVersionhave been deprecated for years. It's time to stop accepting and accommodating them. For now, throw if they're detected to make their use obvious.We want
ManageVersionto default tofalseif not specified. This allows us to detect unsupported upgrade scenarios in more cases. https://www.labkey.org/home/Developer/issues/Secure/issues-details.view?issueId=47369Remove some unused SVN references.