Add container option to ehr billing ext cols #998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-jeckels
approved these changes
Aug 4, 2025
| const ctx = EHR.Utils.getEHRContext(); | ||
| const container = document.getElementById("ehrbilling_container").value; | ||
| if (!container) { | ||
| LABKEY.Utils.alert("Error", "Must enter the container path of the compliance folder."); |
Contributor
There was a problem hiding this comment.
Looks like the wrong message here.
| var ctx = EHR.Utils.getEHRContext(); | ||
| const ctx = EHR.Utils.getEHRContext(); | ||
| const container = document.getElementById("ehrbilling_container").value; | ||
| if (!container) { |
Contributor
There was a problem hiding this comment.
I think this will require a test update:
Contributor
Author
There was a problem hiding this comment.
Thanks for heads up. New PRs opened for broken tests related to this.
https://github.com/LabKey/tnprcEHRModules/pull/149
LabKey/wnprc-modules#861
…fb_ehr_billing_ext_col
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Update extensible col UI to allow ehr billing ext columns in other folders.
Changes