Fix incorrect R syntax #861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ERROR: A pull request from |
Collaborator
Author
|
I am assuming those test failures are not related to this... |
labkey-martyp
approved these changes
Nov 20, 2024
Contributor
labkey-martyp
left a comment
labkey-martyp
left a comment
There was a problem hiding this comment.
Thanks for fixing/improving those.
Contributor
Yes those test failures are unrelated. This can be merged in. Thanks for checking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes two minor improvements:
I noticed the R script in the EHR (which is supposed to document what dependencies are needed), doesnt have valid R code. This is never directly executed, but it might as well be correct.
This adds decimal formatting to the output of the kinship job. Not exactly mission-critical, but a minor improvement that makes it a little easier to see progress.