Skip to content

Constants for many commonly used role names in tests #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-jeckels merged 1 commit into from
Sep 24, 2025
Merged

Constants for many commonly used role names in tests #234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions hdrl/test/src/org/labkey/test/tests/HDRLTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotEquals;
import static org.junit.Assert.assertTrue;
import static org.labkey.test.util.PermissionsHelper.READER_ROLE;

@Category({Git.class})
@BaseWebDriverTest.ClassTimeout(minutes = 8)
Expand Down Expand Up @@ -232,7 +233,7 @@ public void testRetrievalOfResultsAndArchiving() throws Exception

// Verify download
goToProjectHome();
impersonateRole("Reader");
impersonateRole(READER_ROLE);
click(Locator.linkContainingText("View test requests"));
drt = new DataRegionTable("query", this);
idx = drt.getRowIndex("RequestId", requestId);
Expand Down Expand Up @@ -418,7 +419,7 @@ public void testFileUploadAndSubmit()

log("verify submitted requests are readonly for non-admins");

impersonateRole("Reader");
impersonateRole(READER_ROLE);
goToProjectHome();
clickAndWait(Locator.linkContainingText("View test requests"));
drt = new DataRegionTable("query", this);
Expand All @@ -432,7 +433,7 @@ public void testFileUploadAndSubmit()
waitForElement(Locator.tagContainingText("td", "FedEx"));
assertElementNotPresent(org.labkey.test.Locators.bodyTitle("Edit a Test Request"));

testPrintPackingList("Reader", "FedEx");
testPrintPackingList(READER_ROLE, "FedEx");

stopImpersonating();
}
Expand Down