Update MS2 SpectrumImporter to work with Java 25
#967
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Java 25 fixes an inconsistency in the behavior of
File.existswherenew File("")refers to the working directory in most cases butnew File("").existserroneously returnsfalse.SpectrumImporterdepended on the old behavior to determine which file to import.While investigating this issue, I noticed that
PepXmlImporter.processSpectrumFilewon't ever upload the file returned bygetMzXMLFile. This seems to be a regression caused by the latest FileLike changes.Using
FileLikea little more, withnullrepresenting non-existent files (instead of empty Strings) fixes both of these issues.Related Pull Requests
Changes
SpectrumImporterto work with Java 25mzXmlFileimport behavior inPepXmlImporter.processSpectrumFile