Fix flow test failure - int vs long #948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for (Number count : counts.values()) | ||
| totalCount += count.longValue(); | ||
| Map<Integer, Number> counts = FlowManager.get().getUsageCount(primary._type, primary._rowId); |
Contributor
There was a problem hiding this comment.
I probably would have just change this to counts.get(primary._rowId.longValue())
It really doesn't matter either way here, but the idea was start using Map<Long,?> everywhere was to just future proof for any future migrations. Also just the general idea of "Long is the Integer".
Contributor
Author
There was a problem hiding this comment.
OK, I switched back to long. There's a bunch of other code here using ints for these values that I didn't try to address.
labkey-matthewb
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The exp.Object BIGINT conversion looks like it accidentally migrated this use from
IntegertoLongthough the flow.Object table is still using ints.https://teamcity.labkey.org/buildConfiguration/LabkeyTrunk_DailyCPostgres/3717647?buildTab=tests&status=failed&name=FlowSpecimenTest
Changes
Longmore consistently