Skip to content

Fix MS2 filepath #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
XingY merged 1 commit into from
Sep 29, 2025
Merged

Fix MS2 filepath #934

XingY merged 1 commit into from
Sep 29, 2025

Conversation

@XingY
Copy link
Contributor

@XingY XingY commented Sep 29, 2025

Rationale

The effort to clean up file path warnings shows usages of relative and absolute filepath in MS2.

Related Pull Requests

Changes

  • Update LibraTest to set pipeline root at higher level so it won't trip on invalid path error
  • Prefer to return missing mzXMLFile that's under pipeline root, then without parent path (which is tomcat root).

@XingY XingY mentioned this pull request Sep 29, 2025
Merged
@XingY XingY merged commit 56e527e into develop Sep 29, 2025
9 checks passed
@XingY XingY deleted the fb_filePathWarning branch September 29, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@labkey-jeckels labkey-jeckels labkey-jeckels approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@XingY @labkey-jeckels