Support full data file paths in Signal Data metadata #921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgrade code to make DataFile field not required
labkey-nicka
approved these changes
Aug 26, 2025
| name: field.name, | ||
| type: 'string' | ||
| type: 'string', | ||
| convert: field.fieldKey === 'DataFile' ? fileNameFromPath : null |
Contributor
There was a problem hiding this comment.
Use the DATA_FILE constant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
related issue
The signal data metadata file that a client uses is generated via a script that writes the full path of the file to upload. Their current workflow requires them to manually strip off the path portion of the file in order to use the tool. This change helps automate their workflow by stripping off anything other than the file name portion.
Additional changes:
ResultDatafield is no longer required