Issue 53620: Luminex import update to writeSameCheckboxCell to use "disabled" behavior instead of hiding the column inputs #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isabled" behavior instead of hiding the column inputs
3 tasks
labkey-klum
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=53620
For the last step of the Luminex assay import, we have been hiding column inputs when the "Same" checkbox is clicked. This causes some user confusion about what values will actually be submitted for those hidden inputs. This PR instead disables those inputs instead of hiding them (note: not actually using the disabled prop of the input as that prevents the value from being submitted).
Related Pull Requests
Changes