Support BIGINT Primary Keys #912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alue (rowId, objectId, etc).
bulk search/replace
|
WARNING: This PR appears to have the default title generated by GitHub. Please use something more descriptive. |
labkey-nicka
reviewed
Aug 7, 2025
viability/resources/schemas/dbscripts/postgresql/viability-25.000-25.001.sql
Outdated
Show resolved
Hide resolved
probably need a new helpers like isIntegerObject() // instanceof Integer or Long asIntegerOrNull() // null if not isIntegerObject() asLongOrNull() // null if not isIntegerObject()
labkey-adam
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Implement support for tables with BIGINT primary keys. E.g. RowId/ObjectId BIGSERIAL
Because of the large number of shared classes, utilities, services, etc, a lot of code was migrated to used Long. Code should now assume that an generic integer object key (as opposed to a known table PK), could be a Long.
This PR is aimed at a) Supporting ObjectID BIGSERIAL b) making it possible (but not automatic) to migrate tables that want to use RowId BIGSERIAL.
Related Pull Requests
Changes
New safer collection classes
class Int/LongHashMap
class Int/LongHashSet
explicit Class for key values in Map Objects returned by BaseSelector
Selector.getValueMap(Class key)
safe "cast" using asInteger or asLong, as opposed to (Integer) and (Long)