Delete MS2 GWT code. Switch to simple job launcher #830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
labkey-adam
approved these changes
Feb 11, 2025
| public static String DYNAMIC_N_TERM_PEPTIDE_MOD = "refine, potential N-terminus modifications"; | ||
| public static String ENZYME = "protein, cleavage site"; | ||
| public static String SEQUENCE_DB = "pipeline, database"; | ||
| public static String TAXONOMY = "protein, taxon"; |
|
|
||
| public class ParameterNames | ||
| { | ||
| public static String STATIC_MOD = "residue, modification mass"; |
Contributor
There was a problem hiding this comment.
Make all of these final? Looks like the code that mutated some of these statics (?!) is gone.
Contributor
Author
There was a problem hiding this comment.
I don't think they were ever mutated, but were never declared final when they existed in the GWT code
Contributor
There was a problem hiding this comment.
SearchFormCompositeFactory mutated a few of these "constants." Fortunately, you deleted the evil class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
We are removing GWT-based code, including the MS2 protocol designer and job launcher. We can use the simpler XML-based implementation from the pipeline module.
Related Pull Requests
Changes