Test updates to run on firefox 128 #669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-klum
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
A bunch tests started failing in firefox 128
🔶CDSVisualizationTest.verifyLogAndLinearScales
SVG did not look as expected
Firefox 128 caused this test failure
🔶CDSPlotTimeTest.verifyDiscreteTimeVariables
SVG did not look as expected
Firefox 128 caused this test failure
🔶CDSVisualizationPlotTest.verifyBinnedPlot
Expected over 2000 bin squares found: 1990
Firefox 128 caused this test failure
🔶CDSLearnAboutExportTest.testExportExcelDownload
Incorrect number of rows imported expected:<1> but was:<2>
Firefox 128 caused this test failure
Related Pull Requests
Changes