Skip to content

Annotate overrides to suppress warnings in BaseWebPartFactory #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-adam merged 1 commit into from
Mar 24, 2025
Merged

Annotate overrides to suppress warnings in BaseWebPartFactory #529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SkylineToolsStore/src/org/labkey/skylinetoolsstore/SkylineToolsStoreModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ protected Collection<WebPartFactory> createWebPartFactories()
addLegacyNames("Skyline Tools Store");
}
@Override
public WebPartView getWebPartView(ViewContext portalCtx, Portal.WebPart webPart) throws WebPartConfigurationException
public WebPartView getWebPartView(@NotNull ViewContext portalCtx, Portal.@NotNull WebPart webPart) throws WebPartConfigurationException
{
return new SkylineToolsStoreWebPart();
}
Expand Down
2 changes: 1 addition & 1 deletion signup/src/org/labkey/signup/SignUpModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ protected Collection<WebPartFactory> createWebPartFactories()
BaseWebPartFactory signupWebpart = new BaseWebPartFactory("Sign Up")
{
@Override
public WebPartView getWebPartView(ViewContext portalCtx, Portal.WebPart webPart)
public WebPartView getWebPartView(@NotNull ViewContext portalCtx, Portal.@NotNull WebPart webPart)
{
JspView<SignUpController.SignupForm> view = new JspView("/org/labkey/signup/signupPage.jsp", new SignUpController.SignupForm());
view.setTitle("Sign Up");
Expand Down
3 changes: 2 additions & 1 deletion testresults/src/org/labkey/testresults/TestResultsWebPart.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package org.labkey.testresults;

import org.jetbrains.annotations.NotNull;
import org.labkey.api.data.Container;
import org.labkey.api.view.BaseWebPartFactory;
import org.labkey.api.view.JspView;
Expand All @@ -21,7 +22,7 @@ public TestResultsWebPart()
}

@Override
public WebPartView getWebPartView(ViewContext portalCtx, Portal.WebPart webPart) throws WebPartConfigurationException
public WebPartView getWebPartView(@NotNull ViewContext portalCtx, Portal.@NotNull WebPart webPart) throws WebPartConfigurationException
{
Container c =portalCtx.getContainer();
TestsDataBean bean = null;
Expand Down