Skip to content

Conversation

@vagisha
Copy link
Collaborator

@vagisha vagisha commented Mar 19, 2025

Rationale

When a sky.zip file or its exploded folder are moved, post-import, so that the relative locations of sky.zip and its corresponding .skyd file are non-standard, two ExpData rows are created for the skyd file in the Panorama Public copy pipeline job.

  • The first ExpData (linked to the ExpRun) is created during XAR import.
  • The second ExpData (not linked to the ExpRun) is created in the SkylineDocumentParser.parseChromatograms() method.
    Normally, while running the copy pipeline job, SkylineDocumentParser.parseChromatograms() does not have to create a new ExpData, since an ExpData with the expected path already exists.

Having 2 ExpDatas causes:

  • The skydDataId in TargetedMSRun references an ExpData not linked to the ExpRun. It refers to a file in the 'export' directory which gets deleted after folder import.
  • FK violations during cleanup (CopyExperimentFinalTask.cleanupExportDirectory()) prevents deletion of ExpData corresponding to the skydDataId

Related Pull Requests

Changes

  • Added a method to update skydDataId set on TargetedMSRun if the corresponding ExpData is not associated with an ExpRun.
  • Updated test

@vagisha vagisha marked this pull request as ready for review March 19, 2025 21:44
@vagisha vagisha requested a review from labkey-jeckels March 19, 2025 21:44
@vagisha vagisha merged commit 7744f24 into release24.11-SNAPSHOT Mar 22, 2025
4 checks passed
@vagisha vagisha deleted the 24.11_fb_fix-skydDataId branch March 22, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants