Fix skydDataId on TargetedMSRun #526
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
When a sky.zip file or its exploded folder are moved, post-import, so that the relative locations of sky.zip and its corresponding .skyd file are non-standard, two ExpData rows are created for the skyd file in the Panorama Public copy pipeline job.
SkylineDocumentParser.parseChromatograms()method.Normally, while running the copy pipeline job,
SkylineDocumentParser.parseChromatograms()does not have to create a new ExpData, since an ExpData with the expected path already exists.Having 2 ExpDatas causes:
CopyExperimentFinalTask.cleanupExportDirectory()) prevents deletion of ExpData corresponding to the skydDataIdRelated Pull Requests
Changes